Make tailwind working #51
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change using @tailwind directive in styled-jsx component lead to styled-jsx-plugin-postcss] postcss failed with TypeError [ERR_INVALID_ARG_TYPE]: The "url" argument must be of type string. Received type boolean (false) According to postcss documentation (https://postcss.org/api/#processoptions) the 'from' option should be a string of the filename. We should get this filename as options.babel.filename (See: https://github.com/vercel/styled-jsx#plugin-options). Since we don't use the source maps they are now disabled as well.
giuseppeg
reviewed
Mar 26, 2021
processor.js
Outdated
|
|
||
| return loaderPromise | ||
| .then((plugins) => postcss(plugins).process(src, { from: false })) | ||
| .then((plugins) => postcss(plugins).process(src, { from: options.babel.filename, map: false })) |
Owner
There was a problem hiding this comment.
This will break if options.babel is undefined. Can you add a guard?
Author
There was a problem hiding this comment.
Sure, I've added a fallback. Just to let you known: I couldn't test it in my setup anymore, since I ended up not relying on this plugin.
johncomposed
added a commit
to johncomposed/styled-jsx-plugin-postcss
that referenced
this pull request
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change using @tailwind directive in styled-jsx component lead to
styled-jsx-plugin-postcss] postcss failed with TypeError [ERR_INVALID_ARG_TYPE]:
The "url" argument must be of type string. Received type boolean (false)
According to postcss documentation (https://postcss.org/api/#processoptions) the
'from' option should be a string of the filename. We should get this filename as
options.babel.filename (See: https://github.com/vercel/styled-jsx#plugin-options).
Since we don't use the source maps they are now disabled as well.